Skip to content

Add test for org.bukkit.craftbukkit.entity.CraftMinecart#minecartEntityTypeToMaterial#11535

Closed
Abelkrijgtalles wants to merge 119 commits into
PaperMC:masterfrom
Abelkrijgtalles:minecartEntityTypeToMaterial-test
Closed

Add test for org.bukkit.craftbukkit.entity.CraftMinecart#minecartEntityTypeToMaterial#11535
Abelkrijgtalles wants to merge 119 commits into
PaperMC:masterfrom
Abelkrijgtalles:minecartEntityTypeToMaterial-test

Conversation

@Abelkrijgtalles
Copy link
Copy Markdown
Contributor

Hi, I hope you're having a wonderful day.
I've added a test for org.bukkit.craftbukkit.entity.CraftMinecart#minecartEntityTypeToMaterial, as requested in #11511.
In the current approach I've hardcoded the Minecart types, as is done in the function.

Machine-Maker and others added 28 commits October 26, 2024 12:50
Also removes the `info.mobCategoryCounts.mergeInt` call that - at least from what I can tell - has been wrongly counting spawned mobs twice. The runner passed via `info::afterSpawn` already counts up that exact number in the same exact places (where `j`, the return value used here, is incremented)
Mostly an aesthetic change for serialization, should not have any impact on performance or correctness.
* remove leftover timings calls

* remove unused imports
#11524)

When enabled, ender pearls will not load chunks and will save to the world instead of the player.

Also changes the exploit config to be default false, as it only makes sense when legacy behavior is enabled.
@Abelkrijgtalles Abelkrijgtalles requested a review from a team as a code owner October 30, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.